use with compiler flags in key of cached project config #8819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Mar 6, 2023
| return (configPath, distProjectFile "") | ||
| return (configPath, distProjectFile "", | ||
| (projectConfigHcFlavor, projectConfigHcPath, projectConfigHcPkg), | ||
| progsearchpath, |
There was a problem hiding this comment.
Does this mean that if I run cabal in a directory with a slightly modified PATH, then it's going to be a complete cache miss on everything? Even it doesn't change what ghc etc. gets picked? direnv users will be sad if so.
There was a problem hiding this comment.
My understanding is this will only be a cache miss on parsing and evaluating the conditionals in a project file, which should be pretty low-cost. But we certainly need to give this a workout to be sure.
Kleidukos
approved these changes
May 5, 2023
|
Lovely, let's set it for merge then. |
mergify
bot
added
the
merge delay passed
mergify
bot
deleted the
gb/check-compiler-for-project-conditional-rebuilds
branch
kylixafonso
pushed a commit
to kylixafonso/cabal
that referenced
this pull request
May 21, 2023
* use with compiler flags in key of cached project config * changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
|
@mergify backport 3.10 |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jun 17, 2023
* use with compiler flags in key of cached project config * changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9610438)
Kleidukos
pushed a commit
that referenced
this pull request
Jun 17, 2023
* use with compiler flags in key of cached project config * changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9610438)
mergify bot
added a commit
that referenced
this pull request
Jun 17, 2023
use with compiler flags in key of cached project config (backport #8819)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8772, #8699
adds more keys to the cache in rebuildProjectConfig, to ensure it gets rebuilt when the compiler may change.